Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/is 879 invalid receipt #1712

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Bug/is 879 invalid receipt #1712

merged 5 commits into from
Nov 3, 2023

Conversation

dimalit
Copy link
Contributor

@dimalit dimalit commented Oct 30, 2023

  1. When querying DB for transaction location (i.e. block and position), additionally ask for receipt.
  2. If receipt contains 0 gasUsed AND transaction location came from cache - requery it from DB.

Tested with unit test in SkaleHost.cpp

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #1712 (7ba33e3) into develop (931740b) will decrease coverage by 0.05%.
Report is 1 commits behind head on develop.
The diff coverage is 86.00%.

❗ Current head 7ba33e3 differs from pull request most recent head ad847ed. Consider uploading reports for the commit ad847ed to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1712      +/-   ##
===========================================
- Coverage    45.27%   45.23%   -0.05%     
===========================================
  Files          349      349              
  Lines        51409    51448      +39     
===========================================
- Hits         23276    23273       -3     
- Misses       28133    28175      +42     

@dimalit dimalit merged commit 6f3f330 into develop Nov 3, 2023
6 checks passed
@dimalit dimalit deleted the bug/IS-879-invalid-receipt branch November 3, 2023 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants