Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skaled 1674 kill snapsot sending monitoring thread #1676

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

dimalit
Copy link
Contributor

@dimalit dimalit commented Sep 27, 2023

if skaled is sending snapshot, and is asked to exit - it should kill threads that monitor snapshot sending timeouts
Fixes #1674

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #1676 (3d5f19b) into develop (28a3458) will increase coverage by 0.00%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1676   +/-   ##
========================================
  Coverage    44.96%   44.96%           
========================================
  Files          347      347           
  Lines        51283    51283           
========================================
+ Hits         23058    23059    +1     
+ Misses       28225    28224    -1     

@DmytroNazarenko DmytroNazarenko merged commit 12cdeaf into develop Sep 28, 2023
8 checks passed
@DmytroNazarenko DmytroNazarenko deleted the SKALED-1674-thread-kill branch September 28, 2023 16:44
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion in Skale destructor
3 participants