Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1672 add stats to selfdestruct #1673

Merged
merged 15 commits into from
Sep 28, 2023
Merged

1672 add stats to selfdestruct #1673

merged 15 commits into from
Sep 28, 2023

Conversation

kladkogex
Copy link
Collaborator

@kladkogex kladkogex commented Sep 26, 2023 •
edited
Loading

Add stats to self destruct and print patch timestamp info on startup

@github-actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@kladkogex kladkogex self-assigned this Sep 26, 2023
@kladkogex kladkogex linked an issue Sep 26, 2023 that may be closed by this pull request
Add statistics printing to selfdestruct #1672
Closed
@kladkogex kladkogex added this to the 2.2 milestone Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #1673 (28a3458) into develop (99d7035) will decrease coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1673      +/-   ##
===========================================
- Coverage    44.96%   44.96%   -0.01%     
===========================================
  Files          340      347       +7     
  Lines        51249    51283      +34     
===========================================
+ Hits         23046    23058      +12     
- Misses       28203    28225      +22

@DmytroNazarenko DmytroNazarenko removed this from the 2.2 milestone Sep 27, 2023
@DmytroNazarenko DmytroNazarenko merged commit 421c3db into develop Sep 28, 2023
8 checks passed
@DmytroNazarenko DmytroNazarenko deleted the 1672_add_stats_to_selfdestruct branch September 28, 2023 10:23
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@dimalit dimalit dimalit approved these changes

@olehnikolaiev olehnikolaiev Awaiting requested review from olehnikolaiev

@sergiy-skalelabs sergiy-skalelabs Awaiting requested review from sergiy-skalelabs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add statistics printing to selfdestruct
3 participants
@kladkogex @dimalit @DmytroNazarenko