Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA-976 Exit 0 if internal exit reason #1649

Merged
merged 2 commits into from
Sep 15, 2023
Merged

SA-976 Exit 0 if internal exit reason #1649

merged 2 commits into from
Sep 15, 2023

Conversation

dimalit
Copy link
Contributor

@dimalit dimalit commented Sep 15, 2023

No description provided.

@github-actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@dimalit dimalit linked an issue Sep 15, 2023 that may be closed by this pull request
Admin restarts skaled container instead of recreating after node rotation skalenetwork/skale-admin#976
Closed
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #1649 (238cb82) into develop (ff4781e) will increase coverage by 1.84%.
Report is 1 commits behind head on develop.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1649      +/-   ##
===========================================
+ Coverage    43.06%   44.90%   +1.84%     
===========================================
  Files          340      340              
  Lines        51248    51248              
===========================================
+ Hits         22071    23014     +943     
+ Misses       29177    28234     -943

@DmytroNazarenko DmytroNazarenko merged commit 8564160 into develop Sep 15, 2023
6 of 7 checks passed
@DmytroNazarenko DmytroNazarenko deleted the bug/SA-976-exit-1 branch September 15, 2023 20:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@olehnikolaiev olehnikolaiev olehnikolaiev approved these changes

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@kladkogex kladkogex Awaiting requested review from kladkogex kladkogex is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin restarts skaled container instead of recreating after node rotation
3 participants
@dimalit @DmytroNazarenko @olehnikolaiev