Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1560 slow catchup #1593

Merged
merged 5 commits into from
Jul 18, 2023
Merged

1560 slow catchup #1593

merged 5 commits into from
Jul 18, 2023

Conversation

kladkogex
Copy link
Collaborator

@kladkogex kladkogex commented Jul 13, 2023 •
edited
Loading

Fixes the tests

@github-actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@kladkogex kladkogex self-assigned this Jul 13, 2023
@kladkogex kladkogex added this to the 2.2 milestone Jul 13, 2023
@kladkogex kladkogex linked an issue Jul 13, 2023 that may be closed by this pull request
Skaled sleeps for empty block interval during catchup under load #1560
Closed
@codecov
Copy link

codecov bot commented Jul 13, 2023 •
edited
Loading

Codecov Report

Merging #1593 (4ea4bd3) into develop (70e90c8) will increase coverage by 8.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1593      +/-   ##
===========================================
+ Coverage    37.16%   45.19%   +8.03%     
===========================================
  Files          339      339              
  Lines        51289    51289              
===========================================
+ Hits         19061    23182    +4121     
+ Misses       32228    28107    -4121

@olehnikolaiev olehnikolaiev self-requested a review July 14, 2023 12:02
@olehnikolaiev olehnikolaiev merged commit 1807c3a into develop Jul 18, 2023
@olehnikolaiev olehnikolaiev deleted the 1560_slow_2 branch July 18, 2023 09:14
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@olehnikolaiev olehnikolaiev olehnikolaiev approved these changes

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

Assignees

@kladkogex kladkogex

Labels
release:2.2
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

Skaled sleeps for empty block interval during catchup under load
4 participants
@kladkogex @DmytroNazarenko @olehnikolaiev @dmytrotkk