fix: clear module options cache

sitkoru · Jun 24, 2024 · 11e8dcc · 11e8dcc
1 parent ca62c43
commit 11e8dcc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/Sitko.Core.App/ApplicationModuleRegistration.cs b/src/Sitko.Core.App/ApplicationModuleRegistration.cs
@@ -141,6 +141,8 @@ public override (bool isSuccess, IEnumerable<Type> missingModules) CheckRequired
 
     public override bool IsEnabled(IApplicationContext context) => CreateOptions(context).Enabled;
 
+    public override void ClearOptionsCache() => optionsCache.Clear();
+
     private TModuleOptions CreateOptions(IApplicationContext applicationContext, bool validateOptions = false)
     {
         TModuleOptions options;
@@ -261,4 +263,6 @@ public abstract (bool isSuccess, IEnumerable<Type> missingModules) CheckRequired
         Type[] registeredModules);
 
     public abstract bool IsEnabled(IApplicationContext context);
+
+    public abstract void ClearOptionsCache();
 }
diff --git a/src/Sitko.Core.App/SitkoCoreBaseApplicationBuilder.cs b/src/Sitko.Core.App/SitkoCoreBaseApplicationBuilder.cs
@@ -236,6 +236,10 @@ protected virtual LoggerConfiguration ConfigureDefautLogger(LoggerConfiguration
     protected virtual void BeforeContainerBuild()
     {
         var enabledModules = ModulesHelper.GetEnabledModuleRegistrations(BootApplicationContext, moduleRegistrations);
+        foreach (var applicationModuleRegistration in enabledModules)
+        {
+            applicationModuleRegistration.ClearOptionsCache();
+        }
         serilogConfigurator.ApplyLogging(BootApplicationContext, enabledModules);
         foreach (var postConfigureCallback in moduleConfigurationCallbacks)
         {