CodeQL #2132
Annotations
11 warnings
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Autobuild:
src/Sitko.Core.App/Collections/EquatableDictionary.cs#L3
'EquatableDictionary<TKey, TValue>' overrides Object.Equals(object o) but does not override Object.GetHashCode()
|
|
Autobuild:
src/Sitko.Core.App/ApplicationModuleRegistration.cs#L147
Prefer comparing 'Count' to 0 rather than using 'Any()', both for clarity and for performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1860)
|
|
Autobuild:
src/Sitko.Core.App/CommandsModule.cs#L31
Avoid creating a new 'JsonSerializerOptions' instance for every serialization operation. Cache and reuse instances instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1869)
|
|
Autobuild:
src/Sitko.Core.App/Localization/JsonStringLocalizer.cs#L31
Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1510)
|
|
Autobuild:
src/Sitko.Core.App/Localization/JsonStringLocalizer.cs#L16
Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1510)
|
|
Autobuild:
src/Sitko.Core.App/HostedLifecycleService.cs#L5
Type 'HostedLifecycleService' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
|
|
Autobuild:
src/Sitko.Core.App/ApplicationLifecycle.cs#L8
Type 'ApplicationLifecycle' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
|
|
Autobuild:
src/Sitko.Core.App/Logging/SerilogConfigurator.cs#L6
Type 'SerilogConfigurator' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
|
|
Autobuild:
src/Sitko.Core.App/HostApplicationBuilderExtensions.cs#L27
Type 'ProxyHostBuilder' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
|
|
Autobuild:
src/Sitko.Core.App/ApplicationArgsProvider.cs#L3
Type 'ApplicationArgsProvider' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
|
Loading