Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Adjust to interface changes from Neos 9 #221

Merged
merged 1 commit into from
Sep 11, 2023
Merged

TASK: Adjust to interface changes from Neos 9 #221

merged 1 commit into from
Sep 11, 2023

Conversation

mficzel
Copy link
Member

@mficzel mficzel commented Sep 7, 2023 •
edited
Loading

Adjust to interface changes from neos/neos-development-collection#4425

@mficzel mficzel marked this pull request as draft September 7, 2023 16:40
@mficzel mficzel changed the title TASK: Adjust to interface changes from https://github.com/neos/neos-d… TASK: Adjust to interface changes from https://github.com/neos/neos-development-collection/pull/4425 Sep 7, 2023
@mficzel mficzel changed the title TASK: Adjust to interface changes from https://github.com/neos/neos-development-collection/pull/4425 TASK: Adjust to interface changes from neosPr:4425 Sep 7, 2023
@mficzel mficzel force-pushed the task/adjustToChangesInFusionDefaultContextHandling branch 2 times, most recently from fd7a552 to 1ca8ac8 Compare September 8, 2023 07:25
@mficzel mficzel mentioned this pull request Sep 8, 2023
Merged
6 tasks
@mficzel mficzel force-pushed the task/adjustToChangesInFusionDefaultContextHandling branch from 1ca8ac8 to cc02737 Compare September 8, 2023 07:29
@mhsdesign
Copy link
Contributor

Looks good, additionally i think we have a "extend" that is currently useless: #222

@mficzel mficzel force-pushed the task/adjustToChangesInFusionDefaultContextHandling branch from cc02737 to c1d3460 Compare September 8, 2023 12:42
@mficzel mficzel force-pushed the task/adjustToChangesInFusionDefaultContextHandling branch from c1d3460 to ff57f98 Compare September 8, 2023 12:50
mficzel
mficzel commented Sep 10, 2023
View reviewed changes
Copy link
Member Author

@mficzel mficzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change but get errors while testing locally in the backend end frontend. Other than that i would only suggest to adjust some nitpics.

@mficzel mficzel marked this pull request as ready for review September 10, 2023 20:55
@mficzel mficzel merged commit b20da73 into main Sep 11, 2023
@mficzel mficzel changed the title TASK: Adjust to interface changes from neosPr:4425 TASK: Adjust to interface changes from neos 9 Pr:4425 Sep 11, 2023
@mficzel mficzel changed the title TASK: Adjust to interface changes from neos 9 Pr:4425 TASK: Adjust to interface changes from Neos 9 Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsdesign mhsdesign mhsdesign left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mficzel @mhsdesign