TASK: Fix errors in static analysis and add tests with php 8

sitegeist · Apr 1, 2022 · 55a413d · 55a413d
1 parent 2ec5ba5
commit 55a413d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -13,8 +13,17 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                php-versions: ['7.3', '7.4']
-                neos-versions: ['5.3', '7.0', '7.1']
+                php-versions: ['7.4', '8.0']
+                neos-versions: ['7.3']
+                include:
+                  - php-versions: '7.3'
+                    neos-versions: '5.3'
+                  - php-versions: '7.3'
+                    neos-versions: '7.0'
+                  - php-versions: '7.3'
+                    neos-versions: '7.1'
+                  - php-versions: '7.3'
+                    neos-versions: '7.2'
 
         runs-on: ubuntu-latest
 

diff --git a/Classes/Controller/DummyImageController.php b/Classes/Controller/DummyImageController.php
@@ -48,7 +48,7 @@ class DummyImageController extends ActionController
     /**
      * @Flow\InjectConfiguration
      *
-     * @var array
+     * @var mixed[]
      */
     protected $settings;
 
@@ -57,7 +57,7 @@ class DummyImageController extends ActionController
      * with a static Imagick instance,
      * because Vips does not yet support draw
      */
-    public function initializeObject()
+    public function initializeObject(): void
     {
         if (isset($this->settings['dummyImage']['overrideImagineDriver']) && $this->settings['dummyImage']['overrideImagineDriver'] !== false) {
             $className = 'Imagine\\'.$this->settings['dummyImage']['overrideImagineDriver'].'\\Imagine';