Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Pluto Compatible #151

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Karthik-avj
Copy link
Contributor

Added compatible for Pluto.jl as mentioned in #145.

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Merging #151 (04d965f) into master (080b396) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   85.74%   85.74%           
=======================================
  Files          41       41           
  Lines        2014     2014           
=======================================
  Hits         1727     1727           
  Misses        287      287           
Flag Coverage Δ
unittests 85.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mykelk mykelk requested a review from mossr April 26, 2023 14:16
@mykelk
Copy link
Member

mykelk commented Dec 31, 2023

All that is required is adding Pluto as a dependency? I'm not sure we want that. If we actually need it, can it be a weak dependency loaded as a package extension (introduced in Julia 1.9)?

@mossr
Copy link
Member

mossr commented Jan 1, 2024

I agree with Mykel. @Karthik-avj could you explain how adding Pluto to the Project.toml helps make BayesNets compatible? You can already add BayesNets to any Pluto notebook without this addition.

@mossr
Copy link
Member

mossr commented Jan 22, 2024

@Karthik-avj This is a Pluto plotting issue and not a dependency issue with BayesNets.jl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants