Implement OnCompleted prop for Slider #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeparlefrancais
approved these changes
Jun 24, 2024
| @@ -20,6 +20,7 @@ | |||
|
|
|||
| Use the `Arrows` and `Slider` props to specify whether up/down arrows and a slider should be | |||
| included. If arrows or a slider are displayed, they will increment the value by the amount of the step. | |||
| Completing a slide with a slider will call the `OnSubmitted` prop (if provided) with the latest value. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
OnCompletedcallback prop to Slider which is called with the most recent slider value when sliding is finished. It is also called when, during sliding, the component becomes Disabled via props or is unmounted. NumericInput has also been updated to pass itsOnSubmittedcallback prop through to the companion Slider'sOnCompletedprop when specified.Closes #45