Skip to content

Commit

Permalink
update tests for python_modules/libraries/CONTRIBUTING.md (dagster-io…
Browse files Browse the repository at this point in the history
…#15988)

dir scanning based tests were not ready for this file to be here, handle
it

## How I Tested These Changes

bk
  • Loading branch information
alangenfeld authored and sirawats committed Aug 24, 2023
1 parent 60afafa commit 9cee20d
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,11 @@ def build_repo_wide_check_manifest_steps() -> List[CommandStep]:

commands = [
"pip install check-manifest",
*(f"check-manifest {library}" for library in published_packages),
*(
f"check-manifest {library}"
for library in published_packages
if not library.endswith("CONTRIBUTING.md") # ignore md file in dir
),
]

return [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ def test_resource_telemetry():

libraries_dir = file_relative_path(__file__, "../../../libraries")

libraries = [library.name.replace("-", "_") for library in os.scandir(libraries_dir)]
libraries = [
library.name.replace("-", "_")
for library in os.scandir(libraries_dir)
if not library.name.endswith("CONTRIBUTING.md")
]
libraries.append("dagster")

# dagster-ge is out of date and is not installed in the dev environment
Expand Down
2 changes: 2 additions & 0 deletions python_modules/automation/automation_tests/test_repo.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ def test_all_libraries_register() -> None:
assert str(library_dir).endswith("python_modules/libraries")

for library in os.listdir(library_dir):
if library.endswith("CONTRIBUTING.md"):
continue
result = subprocess.run(["grep", register_call, (library_dir / library), "-r"])
assert (
result.returncode == 0
Expand Down

0 comments on commit 9cee20d

Please sign in to comment.