Return result percentage as fraction #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalen
reviewed
Mar 13, 2024
sio/executors/checker.py
Outdated
| output_is_percent = re.match(r"^[0-9]+$", output_str) | ||
| output_is_fraction = re.match(r"^[0-9]+ [0-9]+$", output_str) | ||
| if output_is_float: | ||
| return float_to_fraction(output_str) |
There was a problem hiding this comment.
it can be simplified with:
Decimal(output_str).as_integer_ratio()
There was a problem hiding this comment.
actually it can be simplified even more. python class Fraction supports formats:
- A/B Fraction("42/123").as_integer_ratio()
- A (like Fraction("42").as_integer_ratio()
- A.B (like Fraction("42.123").as_integer_ratio())
twalen
reviewed
Mar 13, 2024
… result-percentage-fraction # Conflicts: # sio/executors/checker.py
top-sekret
pushed a commit
to top-sekret/sioworkers
that referenced
this pull request
Dec 2, 2024
* Result percentage changed to a fraction * Fix typos * Extend tests * More tests * More error checking * Simplified result percentage string parsing. * Added division by zero error handling. * Added and changed tests. * fix: added fraction package * fixed attribute error * fixed type error * fixed tests --------- Co-authored-by: Zonkil <[email protected]> (cherry picked from commit cd195e5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now sioworkers will return a tuple which represents a fraction of the points that the checker assigned. There are 3 formats:
[0-9]+[0-9]+.[0-9]+[0-9]+ [0-9]+This will allow more precise point assignment. Related sio2project/oioioi#332