Merge pull request #19 from sinri/latest

3.2.8 Fix Bug in 3.2.7
sinri · May 21, 2024 · e8b253f · e8b253f
2 parents e4aec2a + b5570e7
commit e8b253f
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 7 deletions.
diff --git a/pom.xml b/pom.xml
@@ -6,8 +6,8 @@
 
     <groupId>io.github.sinri</groupId>
     <artifactId>Keel</artifactId>
-    <!--    <version>3.2.7-SNAPSHOT</version>-->
-    <version>3.2.7</version>
+    <!--        <version>3.2.8-SNAPSHOT</version>-->
+    <version>3.2.8</version>
 
     <name>Keel</name>
     <description>

diff --git a/src/main/java/io/github/sinri/keel/servant/queue/KeelQueue.java b/src/main/java/io/github/sinri/keel/servant/queue/KeelQueue.java
@@ -137,7 +137,9 @@ private Future<Void> whenSignalRunCame(KeelQueueNextTaskSeeker nextTaskSeeker) {
                                 task.setQueueWorkerPoolManager(this.queueWorkerPoolManager);
 
                                 return Future.succeededFuture()
-                                        .compose(v -> task.deployMe(new DeploymentOptions().setThreadingModel(ThreadingModel.WORKER)))
+                                        .compose(v -> task.deployMe(new DeploymentOptions()
+                                                .setThreadingModel(ThreadingModel.WORKER)
+                                        ))
                                         .compose(
                                                 deploymentID -> {
                                                     getIssueRecorder().info(r -> r.message("TASK [" + task.getTaskReference() + "] VERTICLE DEPLOYED: " + deploymentID));

diff --git a/src/main/java/io/github/sinri/keel/servant/queue/QueueTaskIssueRecord.java b/src/main/java/io/github/sinri/keel/servant/queue/QueueTaskIssueRecord.java
@@ -11,6 +11,7 @@ public final class QueueTaskIssueRecord extends BaseIssueRecord<QueueTaskIssueRe
     public static final String TopicQueue = "Queue";
 
     public QueueTaskIssueRecord(@Nonnull String taskReference, @Nonnull String taskCategory) {
+        super();
         this.classification("task", "reference:" + taskReference, "category:" + taskCategory);
     }
 
@@ -25,5 +26,4 @@ public String topic() {
     public QueueTaskIssueRecord getImplementation() {
         return this;
     }
-
 }
diff --git a/src/main/java/io/github/sinri/keel/verticles/KeelVerticleImplWithEventLogger.java b/src/main/java/io/github/sinri/keel/verticles/KeelVerticleImplWithEventLogger.java
@@ -27,12 +27,12 @@ public KeelEventLogger getLogger() {
     @Override
     public final void start(Promise<Void> startPromise) {
         this.logger = buildEventLogger();
-        start();
-        startPromise.complete();
+        startAsKeelVerticle(startPromise);
     }
 
     @Override
     public final void start() {
+        this.logger = buildEventLogger();
         this.startAsKeelVerticle();
     }
 

diff --git a/src/main/java/io/github/sinri/keel/verticles/KeelVerticleImplWithIssueRecorder.java b/src/main/java/io/github/sinri/keel/verticles/KeelVerticleImplWithIssueRecorder.java
@@ -24,11 +24,12 @@ public KeelIssueRecorder<T> getIssueRecorder() {
     @Override
     public final void start(Promise<Void> startPromise) {
         this.issueRecorder = buildIssueRecorder();
-        this.start();
+        startAsKeelVerticle(startPromise);
     }
 
     @Override
     public final void start() {
+        this.issueRecorder = buildIssueRecorder();
         this.startAsKeelVerticle();
     }