implement findAll to allow fluent assertions against all elements that match selector #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Hello there 👋,
I believe that, at the moment, the way to make assertions against multiple matches is done through
$assertElement->contains()
and$assertElement->doesntContain()
methods.The limitation of these approaches is that the contains() doesn't allow us to write an assertion that ensures all elements under a given selector respect a specific set of rules.
For example:
"Assert all images being rendered have an 'alt' attribute"
I believe we cannot perform this assertion with the existing resources. Let me know if I'm mistaken.
My proposed solution is the following:
The reasoning behind this proposal is two-fold:
->has->each()
API that exists in the FluentJSON assertionI hope this doesn't go against the philosophy of the package.
I'm looking forward to any feedback or suggestions.