[#159] Improvement/issue 159 validate library version #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre-senna
requested changes
Mar 1, 2024
hyperon_das/query_engines.py
Outdated
| f'Package version conflict error when connecting to remote DAS `{url}`' | ||
| ) | ||
| raise Exception( | ||
| 'The version of the package you provided does not match the version currently running on the server.' |
There was a problem hiding this comment.
The error message should provide both, the given version and the required one.
andre-senna
approved these changes
Mar 4, 2024
|
@levisingularity Please review this PR as well to make sure client/handle communication is OK |
added 2 commits
March 11, 2024 11:28
levisingularity
approved these changes
Mar 11, 2024
marcocapozzoli
deleted the
improvement/issue-159-validate-library-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #159