Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#203] Review AtomDB tests #212

Merged
merged 6 commits into from
Sep 10, 2024
Merged

[#203] Review AtomDB tests #212

merged 6 commits into from
Sep 10, 2024

Conversation

eddiebrissow
Copy link
Collaborator

@eddiebrissow eddiebrissow commented Sep 5, 2024 •
edited
Loading

Added public API unit tests

angeloprobst
angeloprobst approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@angeloprobst angeloprobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but we should revisit those commented test cases where the Redis/Mongo implementation gives a response different from the RAM-only's one.
Do we already have a ticket for that?

@angeloprobst angeloprobst mentioned this pull request Sep 10, 2024
Closed
@angeloprobst angeloprobst merged commit 3917a45 into master Sep 10, 2024
4 checks passed
@angeloprobst angeloprobst deleted the imp/issue-203-review-unit-and-integration-tests branch September 10, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angeloprobst angeloprobst angeloprobst approved these changes

@andre-senna andre-senna andre-senna approved these changes

@marcocapozzoli marcocapozzoli Awaiting requested review from marcocapozzoli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eddiebrissow @andre-senna @angeloprobst