Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#161] refactoring redis_mongo_db.py and fixing small logic stuff #177

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

angeloprobst
Copy link
Collaborator

@angeloprobst angeloprobst commented Jul 31, 2024

Progress on ticket #161

Refactors redis_mongo_db.py:

  1. Applies black formatting.
  2. Ensures lines width at max 100 chars.
  3. Adds and/or fixes type annotations, mainly returns.
  4. Applies new standard of type annotations (i.e. dict[A, B] | None instead of Optional[Dict[A, B]]).
  5. Adds and/or fixes docstrings.
  6. Ensures the file passes green through pylint.
  7. Fixes some typos.
  8. Left some TODO comments for future evaluation.
  9. Eliminates a while True statement.

@angeloprobst angeloprobst merged commit 6b883d9 into master Jul 31, 2024
4 checks passed
@angeloprobst angeloprobst deleted the angelo/#161/refactoring-redis_mongo_db.py branch July 31, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants