Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change MongoFieldNames to FieldNames #147

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Change MongoFieldNames to FieldNames #147

merged 5 commits into from
Jun 4, 2024

Conversation

marcocapozzoli
Copy link
Collaborator

@marcocapozzoli marcocapozzoli commented May 30, 2024 •
edited
Loading

Resolves #63

andre-senna
andre-senna requested changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@andre-senna andre-senna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the string "is_toplevel" is used all around the code, no? Adding a key in this enum implies changing the places where this string is used to use the newly created enum value.

@marcocapozzoli marcocapozzoli changed the title Added IS_TOPLEVEL in MongoFieldNames Change MongoFieldNames to FieldNames Jun 4, 2024
@marcocapozzoli marcocapozzoli merged commit 36d620c into master Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andre-senna andre-senna andre-senna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a enum value for is_toplevel mongo document field in RedisMongoDB
2 participants
@marcocapozzoli @andre-senna