Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding 2 new notebooks -- gen ai apps with vertex ai and llama index #16

Closed
wants to merge 12 commits into from

Conversation

pranavaurora
Copy link
Contributor

No description provided.

Copy link
Collaborator

@kesmit13 kesmit13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the llama notebook, here are some changes:

  1. For the API key, we've been using import getpass' and os.environ["OPENAI_API_KEY"] = getpass.getpass("Enter OpenAI API key: ")` to prevent people from committing API keys.

  2. Don't set the SINGLESTOREDB_URL, that's already set by the notebook environment.

  3. In the SingleStoreReader, I would think we would use 'singlestoredb' for scheme, connection_host for host, connection_port for port, connection_user for user, and connection_password for password.

  4. The In[9], In[10], and In[11] don't need print functions, the notebook will print the result.

On the vertex notebook:

  1. Remove the SINGLESTOREDB_URL part again.

You'll want to step through both notebooks to make sure they still work.

@pranavaurora
Copy link
Contributor Author

I removed my 2 notebooks which need quite a lot of changes, and have added the changes to Arnaud's meta.toml file so that gallery won't break

@kesmit13
Copy link
Collaborator

I fixed the notebooks myself.

@kesmit13 kesmit13 closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants