Update notebook to support the new Fusion SQL stage resources syntax #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesmit13
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Can you install the pre-commit checks as described here: https://github.com/singlestore-labs/spaces-notebooks/blob/master/CONTRIBUTING.md#pre-commit-checks-on-the-clone-of-this-repo . It looks like the pre-commit checks need to make formatting changes to the notebook file.
nunogoncalves03
force-pushed
the
ngoncalves/fusion-sql-notebook-stage-syntax
branch
from
06b9e06 to
0c5a82c
Compare
kesmit13
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added support for starter workspaces in the
Python SDKstage resources, which updated theFusion SQLsyntax (singlestore-labs/singlestoredb-python#44). Although this change is backward compatible (meaning the old syntax still works properly) we would like to update themanaging-stage-files-with-fusion-sqlnotebook to reflect the newest syntax.Note that while singlestore-labs/singlestoredb-python#44 has been merged, it has not yet been deployed to production. Therefore, we should wait to deploy this PR until the new syntax is in production.
cc: @ricardoasmarques @kanitsharma