Feature/adapt drizzle kit #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| console.log(wrapParam('host', options.host)); | ||
| console.log(wrapParam('port', options.port, true)); | ||
| console.log(wrapParam('user', options.user, true)); | ||
| console.log(wrapParam('password', options.password, true, 'secret')); |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
|
|
||
| statement += it.generated | ||
| ? `.generatedAlwaysAs(sql\`${ | ||
| it.generated.as.replace( |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
| `singlestore://${credentials.user}:${credentials.password}@${credentials.host}:${credentials.port}/${credentials.database}`; | ||
| } | ||
|
|
||
| const dbHash = createHash('sha256').update(dbUrl).digest('hex'); |
Check failure
Code scanning / CodeQL
Use of password hash with insufficient computational effort High
tiagoacastro
reviewed
Aug 8, 2024
tiagoacastro
approved these changes
Aug 13, 2024
Rodriguespn
force-pushed
the
feature/adapt-drizzle-kit
branch
from
5fc2bec to
8084ad6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows us to generate migrations via
generateSingleStoreTable, via Drizzle migrations, which was not possible previously. For the hackathon, we were either creating the tables and the schema on SingleStore Portal or via thegenerateMySqlTablefunction.We still need to add the new columns support to the 'drizzle-kit`.
Work done
mysql2version from 2.3.3 to 3.3.3 to be compatible with the[email protected]used in thedrizzle-orm/singlestoreTest Pipeline
Future Work
Allow drizzle-kit to support singlestore types: