Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes/improvements to SingleStore driver/dialect #17

Merged
merged 7 commits into from
Sep 6, 2024
Merged

Fixes/improvements to SingleStore driver/dialect #17

merged 7 commits into from
Sep 6, 2024

Conversation

mitchwadair
Copy link

@mitchwadair mitchwadair commented Sep 4, 2024 •
edited
Loading

Makes some changes to the driver/dialect to do:

  • removes the mode config option and related code
    • This was only relevant to MySQL because of the planetscale mode
  • Changes SingleStore2 to SingleStoreDriver

@mitchwadair mitchwadair self-assigned this Sep 4, 2024
Rodriguespn
Rodriguespn approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@Rodriguespn Rodriguespn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

We should keep in mind that we use some of these driver classes in the integration tests so we will have to change them on rebase

@mitchwadair
Copy link
Author

LGTM 👍

We should keep in mind that we use some of these driver classes in the integration tests so we will have to change them on rebase

Yeah makes sense, I'll wait for that PR to merge then and I'll rebase this one

@mitchwadair mitchwadair changed the title Fixes/improvements to SingleStore driver Fixes/improvements to SingleStore driver/dialect Sep 5, 2024
@Rodriguespn Rodriguespn changed the base branch from main to feature/singlestore-integration-tests September 6, 2024 15:47
@Rodriguespn Rodriguespn force-pushed the madair/singlestore-driver-fixes branch from eeb05f5 to 8e406fc Compare September 6, 2024 15:51
@mitchwadair mitchwadair force-pushed the madair/singlestore-driver-fixes branch from 8e406fc to 1e61f22 Compare September 6, 2024 15:57
@Rodriguespn Rodriguespn merged commit b478e98 into feature/singlestore-integration-tests Sep 6, 2024
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rodriguespn Rodriguespn Rodriguespn approved these changes

@tiagoacastro tiagoacastro Awaiting requested review from tiagoacastro

@drodrigues4 drodrigues4 Awaiting requested review from drodrigues4

@apeng-singlestore apeng-singlestore Awaiting requested review from apeng-singlestore

Assignees

@mitchwadair mitchwadair

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchwadair @Rodriguespn