Skip to content

Commit

Permalink
Better tab indices when adding a new module.
Browse files Browse the repository at this point in the history
  • Loading branch information
joeldenning committed Dec 18, 2019
1 parent 9ca26e7 commit b30e472
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/ui/list/module-dialog.component.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ export default class ModuleDialog extends Component {
<td style={{ position: "relative" }}>
<input
type="text"
tabIndex={1}
value={this.state.moduleName}
aria-labelledby="module-name-label"
onInput={evt =>
Expand All @@ -81,7 +82,7 @@ export default class ModuleDialog extends Component {
/>
<div
role="button"
tabIndex={0}
tabIndex={3}
className="imo-clear-input"
onClick={this.clearModuleName}
>
Expand All @@ -100,13 +101,14 @@ export default class ModuleDialog extends Component {
type="text"
value={this.state.overrideUrl}
aria-labelledby="override-url-label"
tabIndex={2}
onInput={evt =>
this.setState({ overrideUrl: evt.target.value })
}
/>
<div
role="button"
tabIndex={0}
tabIndex={4}
className="imo-clear-input"
onClick={this.clearInput}
>
Expand All @@ -125,13 +127,15 @@ export default class ModuleDialog extends Component {
<div className="imo-dialog-actions">
<button
type="button"
tabIndex={5}
onClick={this.props.cancel}
style={{ marginRight: "16px" }}
>
Cancel
</button>
<button
type="submit"
tabIndex={6}
className={
this.state.overrideUrl ? "imo-overridden" : "imo-default"
}
Expand Down

0 comments on commit b30e472

Please sign in to comment.