Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Throw error in SOMAVFSFilebuf.open on file-not-found #3565

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Jan 15, 2025

Issue and/or context:

[sc-61909]

Changes:

Fix misleading error by throwing an explicit error in SOMAVFSFilebuf.open if the file does not exist.

@nguyenv nguyenv requested a review from johnkerl January 15, 2025 17:01
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.27%. Comparing base (ac7407e) to head (e65943b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3565      +/-   ##
==========================================
+ Coverage   86.22%   86.27%   +0.04%     
==========================================
  Files          55       55              
  Lines        6410     6410              
==========================================
+ Hits         5527     5530       +3     
+ Misses        883      880       -3     
Flag Coverage Δ
python 86.27% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.27% <ø> (+0.04%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl changed the title [python] Throw error in SOMAVFSFilebuf.open if file DNE [python] Throw error in SOMAVFSFilebuf.open on file-not-found Jan 15, 2025
apis/python/src/tiledbsoma/soma_vfs.cc Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants