Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-1.15] [c++] When a group has no type info, say its name #3532

Merged
merged 5 commits into from
Jan 7, 2025
Merged

[Backport release-1.15] [c++] When a group has no type info, say its name #3532

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
92d5493
temp (#3530)
johnkerl Jan 7, 2025
162c6f8
Fix up C++20 -> 17 on `release-1.15` branch
johnkerl Jan 7, 2025
ccf850b
run make format with clang-format 18.1.3
johnkerl Jan 7, 2025
ac811bd
again ...
johnkerl Jan 7, 2025
42ccb54
Merge branch 'backport-3530-to-release-1.15' of https://github.com/si…
johnkerl Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions libtiledbsoma/src/soma/soma_object.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#include <string>
#include <tiledb/tiledb>

#include "../utils/logger.h" // for fmt
#include "soma_array.h"
#include "soma_collection.h"
#include "soma_dataframe.h"
Expand Down Expand Up @@ -46,8 +47,8 @@ std::unique_ptr<SOMAObject> SOMAObject::open(
auto array_type = array_->type();

if (!array_type.has_value())
throw TileDBSOMAError(
"[SOMAObject::open] SOMAArray has no type info");
throw TileDBSOMAError(fmt::format(
"[SOMAObject::open] SOMAArray '{}' has no type info", uri));

std::transform(
array_type->begin(),
Expand All @@ -74,8 +75,8 @@ std::unique_ptr<SOMAObject> SOMAObject::open(
auto group_type = group_->type();

if (!group_type.has_value())
throw TileDBSOMAError(
"[SOMAObject::open] SOMAGroup has no type info");
throw TileDBSOMAError(fmt::format(
"[SOMAObject::open] SOMAGroup '{}' has no type info", uri));

std::transform(
group_type->begin(),
Expand Down