Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-1.15] [python] Validate byteorder on fastercsx argument arrays #3521

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jan 7, 2025

Backport fbeee6f from #3508

@johnkerl
Copy link
Member

johnkerl commented Jan 7, 2025

This does not immediately backport from main to release-1.15 since we currently have C++20 on main but C++17 on release-1.15

https://github.com/single-cell-data/TileDB-SOMA/actions/runs/12654002797/job/35260823182

  src/tiledbsoma/fastercsx.cc:118:47: error: ‘std::endian’ has not been declared
    118 |     if constexpr (std::endian::native == std::endian::big)

See also #3154

@johnkerl johnkerl force-pushed the backport-3508-to-release-1.15 branch from 66dc0c6 to df5aa64 Compare January 10, 2025 15:13
@johnkerl johnkerl removed the blocked label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.37%. Comparing base (bb22c8b) to head (1d861e5).
Report is 4 commits behind head on release-1.15.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.15    #3521      +/-   ##
================================================
+ Coverage         86.33%   86.37%   +0.04%     
================================================
  Files                55       55              
  Lines              6365     6365              
================================================
+ Hits               5495     5498       +3     
+ Misses              870      867       -3     
Flag Coverage Δ
python 86.37% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.37% <ø> (+0.04%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl self-requested a review January 10, 2025 16:09
@johnkerl johnkerl merged commit 82aa01c into release-1.15 Jan 10, 2025
16 checks passed
@johnkerl johnkerl deleted the backport-3508-to-release-1.15 branch January 10, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants