[python] Add support for Visium v1 #3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now require the version to be found.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3510 +/- ##
==========================================
- Coverage 86.27% 86.27% -0.01%
==========================================
Files 55 55
Lines 6340 6344 +4
==========================================
+ Hits 5470 5473 +3
- Misses 870 871 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ktsitsi
approved these changes
Jan 3, 2025
| if tissue_positions is None: | ||
| major_version = version[0] if isinstance(version, tuple) else version |
There was a problem hiding this comment.
Why not using the property instead?
There was a problem hiding this comment.
The class wasn't created yet.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
1. Explicitly set header columns for 2. Throw error if Visium version number is unknown. 3. Make check for Visium filename version specific (this can be over-ridden by the user).
johnkerl
pushed a commit
that referenced
this pull request
Jan 10, 2025
1. Explicitly set header columns for 2. Throw error if Visium version number is unknown. 3. Make check for Visium filename version specific (this can be over-ridden by the user). Co-authored-by: Julia Dark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: sc-61280
Changes: