[r] Write group-level string metadata as TILEDB_STRING_UTF8
#3469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String group-level metadata was previously encoded using `TILEDB_CHAR` or `TILEDB_STRING_ASCII`; however, this resulting in the metadata being read in as `bytes` in the Python API instead of as `str`. The Python API already [encodes all strings (`str`) as `TILEDB_STRING_UTF8`](https://github.com/single-cell-data/TileDB-SOMA/blob/884342a1ceb994d677c52c74ba2d789fc4e208d4/apis/python/src/tiledbsoma/common.cc#L211-L223) so this PR brings the R API in-line with the Python API [SC-61001](https://app.shortcut.com/tiledb-inc/story/61001) resolves #2698
bkmartinjr
reviewed
Dec 18, 2024
@bkmartinjr please see
@mojaveazure the closing criterion for #2698 is that cross-language test |
mojaveazure
force-pushed
the
paulhoffman/sc-61001/r-python-r-and-python-create-groups-with
branch
from
372ffb8 to
bb678d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3469 +/- ##
=======================================
Coverage 86.32% 86.32%
=======================================
Files 55 55
Lines 6339 6339
=======================================
Hits 5472 5472
Misses 867 867
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@bkmartinjr @johnkerl round-trip checks added in 941745f |
[ci skip]
johnkerl
approved these changes
Dec 18, 2024
Bump develop version [ci skip]
mojaveazure
deleted the
paulhoffman/sc-61001/r-python-r-and-python-create-groups-with
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String group-level metadata was previously encoded using
TILEDB_CHARorTILEDB_STRING_ASCII; however, this resulting in the metadata being read in asbytesin the Python API instead of asstr. The Python API already encodes all strings (str) asTILEDB_STRING_UTF8so this PR brings the R API in-line with the Python APISC-61001
adresses #2698