Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Fix typo in test/unit_soma_dense_ndarray.cc [WIP] #2912

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Aug 17, 2024

Issue and/or context: Found while working on #2785 for issue #2407 / [sc-51048].

Changes:

Create dense when dense is expected. Assert this.

Notes for Reviewer:

This PR is in draft status. There's something else going on with the new unit-test fail, which I need to get to the bottom of. I will file a new tracking issue.

@johnkerl johnkerl requested review from nguyenv and jp-dark August 17, 2024 16:53
@johnkerl johnkerl changed the title [c++] Fix typo in test/unit_soma_dense_ndarray.cc [c++] Fix typo in test/unit_soma_dense_ndarray.cc [WIP] Aug 17, 2024
@johnkerl johnkerl force-pushed the kerl/ctest-dense-typo branch from 6ce1730 to d6582ff Compare August 17, 2024 17:40
@johnkerl johnkerl force-pushed the kerl/ctest-dense-typo branch from d6582ff to d06f11d Compare August 17, 2024 17:56
@johnkerl johnkerl marked this pull request as draft August 17, 2024 23:26
@jp-dark jp-dark removed their request for review December 23, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant