Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Add four add_new_* setters to SOMACollectionBase #1091

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

eddelbuettel
Copy link
Contributor

@eddelbuettel eddelbuettel commented Mar 10, 2023

Issue and/or context:

The PR adds new setters for collection, dataframe, and dense and sparse arrays to collections

Changes:

Four new setters plus tests

Notes for Reviewer:

SC 26349
#938
#839

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #26349: Extend SOMACollection with add_new_* functions.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -18.81 ⚠️

Comparison is base (5fca0d0) 61.17% compared to head (eba8401) 42.36%.

❗ Current head eba8401 differs from pull request most recent head 917d392. Consider uploading reports for the commit 917d392 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1091       +/-   ##
===========================================
- Coverage   61.17%   42.36%   -18.81%     
===========================================
  Files          81       51       -30     
  Lines        5906     3635     -2271     
===========================================
- Hits         3613     1540     -2073     
+ Misses       2293     2095      -198     
Flag Coverage Δ
python ?
r 42.36% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 31 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@johnkerl johnkerl changed the title [r] Add four add_new_* setters to CollectionBase [r] Add four add_new_* setters to SOMACollectionBase Mar 10, 2023
Copy link
Member

@aaronwolen aaronwolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eddelbuettel eddelbuettel merged commit b21f68e into main Mar 12, 2023
@eddelbuettel eddelbuettel deleted the de/sc-26349/add_new_functions branch March 12, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants