Skip to content

Commit

Permalink
Pin pylint in setup.py (#197)
Browse files Browse the repository at this point in the history
* Pin `pylint` in `setup.py`

Here's the first failing CI run
https://app.circleci.com/pipelines/github/singer-io/tap-stripe/2321/workflows/a7a108fe-1dbc-4b9a-ba70-8a540e793990/jobs/17567

> Successfully installed astroid-3.1.0 backoff-2.2.1 certifi-2024.2.2 charset-normalizer-3.3.2 ciso8601-2.3.1 coverage-7.4.3 dill-0.3.8 idna-3.6 isort-5.13.2 jsonschema-2.6.0 mccabe-0.7.0 nose2-0.14.1 platformdirs-4.2.0 pylint-3.1.0 

Here's the last good run
https://app.circleci.com/pipelines/github/singer-io/tap-stripe/2312/workflows/ad468452-6b8a-4e2e-971d-4cdc063f1228/jobs/17439

> Successfully installed astroid-3.0.3 backoff-2.2.1 certifi-2024.2.2 charset-normalizer-3.3.2 ciso8601-2.3.1 coverage-7.4.1 dill-0.3.8 idna-3.6 isort-5.13.2 jsonschema-2.6.0 mccabe-0.7.0 nose2-0.14.1 platformdirs-4.2.0 pylint-3.0.3

* Skip checking the value of `invoices.discount`
  • Loading branch information
luandy64 authored Apr 17, 2024
1 parent 6bbae48 commit 593ae9f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
],
extras_require={
'test': [
'pylint',
'pylint==3.0.3',
'nose2',
'coverage'
],
Expand Down
1 change: 1 addition & 0 deletions tests/test_all_fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@
'hosted_invoice_url', # expect https://invoice.stripe.com/i/acct_14zvmQDcBSxinnbL/test...zcy0200wBekbjGw?s=ap
'invoice_pdf', # get https://invoice.stripe.com/i/acct_14zvmQDcBSxinnbL/test...DE102006vZ98t5I?s=ap
'payment_settings', # 'default_mandate' subfield unexpectedly present
'discount',
'subscription_details'
},
'plans': set(),
Expand Down

0 comments on commit 593ae9f

Please sign in to comment.