Changing round to ceil in calculate_seconds method and including minimum remain rate limit configurable #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re the API key reset" This reverts commit 2d41003.
…ate_seconds method
|
Hi @joaopamaral, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
You did it @joaopamaral! Thank you for signing the Singer Contribution License Agreement. |
Adding last page limit and include config to set the max results per page
Fix releases schema
…tials Add retry attempt to bad credentials error
Not skip 404 on verify repo access
Add Open Issues stream
…ader in the header
…ader in the header
…teLimit-Remaining-in-the-header Remove the exception if no X-RateLimit-Remaining is found in the header
…-if-no-RateLimit-Remaining-in-the-header Revert "Remove the exception if no X-RateLimit-Remaining is found in the header"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The
roundcall incalculate_secondsmethod was making the retry attempt trigger before resetting the API token for less than a second (when the API rate limit is achieved), which causes a new exception that causes the extract to fail. Theceilfix this issue since it makes the request always being made after the reset.The minimum remaining rate limit parameter was included to add the possibility of setting a custom limit remaining rate limit instead of 0. With that config, it's possible to avoid reaching the extreme limit (0 remaining rate limit) and it's important if there are others tokens used by the same user.
Manual QA steps
Risks
Rollback steps