Add import-style rule

[futpib]

fixes #211

---

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

• #211: Rule proposal: Don't import util Node.js core module directly

---

[fisker]

Are we going to allow check `./util'?

[futpib]

I would prefer not to. If we are to support relative paths properly, we are to invite a lot of complexities of eslint-plugin-import (pluggable resolvers). (EDIT: I'm probably wrong about this) I'd rather leave it as undefined behaviour (which it currently is), advise against it in the docs or throw if a relative path is found in options.

[manovotny]

I stumbled across this while looking for a way to enforce the use of const / require instead of accidental import for apps / packages that haven't opted into the experimental support in newer node versions yet.

Do y'all think this would be something appropriate to add to this import-style rule or something completely different? I also didn't see anything else out there in native eslint, but please forgive me if I overlooked something.

[fisker]

I'll take a deep look ASAP.

[fisker]

Looks great ,

1. I didn't see import chalk, {red } from test
2. We agree to check export from in previous PR

[futpib]

@fisker I added export ... from ... support but chose to leave it disabled by default (behind checkExportFrom option).

The original motivation for this rule (as far as I understand) was to force the named import of unrelated functions and default or namespace import of related functions. export ... from ... allows you to turn unrelated-functions-module (like util) into a related-functions-module (like chalk) like this:

export {promisify, callbackify} from 'util';

I think the above code should not be reported. @sindresorhus, hope this decision is fine by you.

[fisker]

All good, 2 notes:

1. I suggest apply this, but it's only a style issue
   Add import-style rule #789 (comment)

2. Add a test about this, I can accept any result about it
   Add import-style rule #789 (comment)

[futpib]

I addressed the remaining review comments.

[sindresorhus]

Great work on this, @futpib 👍🏻