Switch from Travis CI to GitHub Actions #504
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| name: Other | ||
|
|
||
| on: | ||
| - push | ||
| - pull_request | ||
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 12 | ||
| - run: npm install | ||
| - run: npm run lint | ||
| integration: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 12 | ||
| - run: npm install | ||
| - run: npm run integration |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| name: Tests | ||
|
|
||
| on: | ||
| - push | ||
| - pull_request | ||
|
|
||
| jobs: | ||
| test: | ||
| name: Node.js ${{ matrix.node_version }} on ${{ matrix.os }} | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| node_version: | ||
| - 13 | ||
| - 12 | ||
| - 10 | ||
| os: | ||
| - ubuntu-latest | ||
| - windows-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node_version }} | ||
| - run: npm install | ||
| - run: npm run test-coverage | ||
| - uses: coverallsapp/github-action@master | ||
| continue-on-error: true | ||
| with: | ||
| github-token: ${{ secrets.github_token }} | ||
| parallel: true | ||
| - uses: coverallsapp/github-action@master | ||
| continue-on-error: true | ||
| with: | ||
| github-token: ${{ secrets.github_token }} | ||
| parallel-finished: true | ||
|
There was a problem hiding this comment. On my experience, this not right, seem need another job wait for matrix, not sure. I tried in this way before. So I dont use parallel https://github.com/fisker/id-placeholder/blob/ae506a0069bb459f6100f2c317f377ba9f8651de/.github/workflows/continuous-integration.yml#L52 Also, this action some times fail for no reason, issue can found on their repo, so I use continue-on-error There was a problem hiding this comment. The I added the |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,8 @@ | |
| }, | ||
| "scripts": { | ||
| "test": "xo && nyc ava", | ||
| "test-coverage": "nyc --reporter=lcov ava", | ||
| "lint": "node ./test/lint/lint.js && xo", | ||
|
There was a problem hiding this comment. XO is now run twice, both on There was a problem hiding this comment. @sindresorhus Yes and no. In the GitHub CI pipe So, I thought it was best to leave the |
||
| "integration": "node ./test/integration/test.js" | ||
| }, | ||
| "files": [ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fail-fast: false is needed here