Change some options for prevent-abbreviations rule

[fisker]

The PR will make this code bellow report an error by default

const getDocsUrl = require('./utils/get-docs-url');

without breaking #237 (comment)

import tempWrite from 'temp-write';

and

import tempWrite from './node_modules/temp-write';

moduleId starts with . / @/ and without node_modules is considered internal-module.

The internal naming and internal-module logic may need discuss.

//cc @futpib @sindresorhus

[futpib]

What is the meaning of a module name starting with @/?

[fisker]

@ is webpack alias, means project root

[fisker]

reminds me there is also a ~, or maybe we do external check, any thoughts?

[futpib]

Webpack aliases can be absolutely arbitrary and @ as an alias for the root of the project is not something I've seen used. I don't think we should support something that is not even a widespread convention (and definitely not a standard).

Anyway, what is the issue you are trying to solve with this PR?

[fisker]

I want imports report error if name is using abbreviation, but #237 (comment) don't want check npm packages import, so I made this PR to only target internal-modules resolve things like example I wrote in the comment above , and this

eslint-plugin-unicorn/test/get-documentation-url.js

Line 2 in dbf4b79

import pkg from '../package.json';

It's not reported because it's import .

[fisker]

@futpib @sindresorhus Are you ok with this change?

[sindresorhus]

Webpack aliases can be absolutely arbitrary and @ as an alias for the root of the project is not something I've seen used. I don't think we should support something that is not even a widespread convention (and definitely not a standard).

👍

[sindresorhus]

Are you ok with this change?

Yes