prefer-module: allow module as TSIndexSignature names or TSTypeAliasDeclaration ids

[ST-DDT]

Fixes #2208

• prefer-module should not report module name in types #2208

I tried adding a test for that, but was unable to do that (maybe because it requires ts support):

  message: `␊
    > 1 | type ModuleRegistry = { [module: string]: string };␊
        |      ^ Parsing error: Unexpected token ModuleRegistry`,                                                                                                            
  }                                                                                                                                                                          

  » |      ^ Parsing error: Unexpected token ModuleRegistry
  » verify (file:///test/utils/snapshot-rule-tester.mjs:138:9)
  » file:///test/utils/snapshot-rule-tester.mjs:169:23

So I used https://github.com/faker-js/faker/pull/2510/files#diff-7170563e0d86e93e8997b4acb856e5e494809a0ef41b9f4386f26e14bc961908R19 to test that.

[fisker]

Take this as example

eslint-plugin-unicorn/test/no-array-for-each.mjs

Line 571 in 61e6601

test.typescript({

Put your code in valid part.

[ST-DDT]

Take this as example

Thanks for the help.
Is one test sufficient or do we need more?

[fisker]

Added more, but feel free to add more.

Thanks!

[sindresorhus]

Tests are failing

[ST-DDT]

fisker added an additional case where the type name is module.
The additional (failing) test, is also an (expectedly) valid and similar case, but it is different from the issue this PR originally tried to fix.

I'm not sure how I can fix that. Is there a way to run only a specific test? Maybe then I can try to debug it.

[fisker]

I'll take a look.

[ST-DDT]

@fisker It looks like we missed a case:

type Data = {
  [module in 'foo']: number;
};

e.g.

type Data = {
  [module in keyof string]: number;
};

I could prepare a PR for that, but for that I need to know how I can run a specific test(case) only.

[fisker]

I need to know how I can run a specific test(case) only.

Currently we don't support it yet. But it should be possible if we upgrade eslint-ava-rule-tester https://github.com/jfmengels/eslint-ava-rule-tester/releases/tag/v4.1.0

[ST-DDT]

I used a workaround, aka deleting all tests except for the one I wanted and created a PR with the fix:

• prefer-module: allow module as TSTypeParameter name #2213