Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of views based on routing implemented (All Planets) #14

Conversation

kiprotichdominic
Copy link
Contributor

  • Created the page for viewing a film detail which can also enable a user to view characters

Copy link
Contributor

@otsembo otsembo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @kiprotichdominic
You still have a failing CI check.

Kindly fix it and push your code.

@github-actions
Copy link

github-actions bot commented Feb 16, 2023

Visit the preview URL for this PR (updated for commit 8bf2668):

https://the-force-8688d--pr14-kiprotich-dominic-tf-djv2owx3.web.app

(expires Mon, 06 Mar 2023 18:53:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c99f54c65afef9a4768713fe64d3ac42ff1580aa

Copy link
Contributor

@otsembo otsembo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @kiprotichdominic

@mutuajoseph mutuajoseph merged commit 0175bf2 into master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants