Fix on emulator-start goal #762
Conversation
| @@ -669,6 +669,7 @@ | |||
| instead --> | |||
| <configLocation>src/conf/maven_checks.xml</configLocation> | |||
| <enableRulesSummary>false</enableRulesSummary> | |||
| <failOnViolation>false</failOnViolation> | |||
There was a problem hiding this comment.
Do not disable this check. Instead ensure that your code passes the style check.
There was a problem hiding this comment.
I don't know what format the maven check plugin wants and as doing it.
There was a problem hiding this comment.
The checkstyle errors will show the details and the codestyle is configured in the maven_checks.xml file. Your IDE should automatically pick it up and hightlight things as well. At least Eclipse does that.
There was a problem hiding this comment.
My Eclipse IDE doesn't apply the format according the maven_checks.xml file.
|
|
||
| 1)SET ANDROID_HOME environment variable and in the path %ANDROID_HOME%/tools and platform-tools | ||
|
|
||
| 2)User properties _android.devices_ or _android.device_ maybe are not supported because will run always the emulator. |
There was a problem hiding this comment.
Because in my method to run android emulator I don't use the "AndroidDebugBridge" object that maybe return the devices set.
|
The file is completely revamped so I cant tell what changed. Please update the PR to limit the changes stick with the code style. |
|
I have refactored the commit history in order to view only the changing done in the Emulator class. |
|
@mosabua any problem to merge the pull request? |
ghost
closed this
ghost
reopened this
|
@mosabua any news to merge this pull request? |
ghost
closed this by deleting the head repository
According the issue: #752,
I have fixed the goal.
Every informations about the fix are: https://github.com/amanganiello90/android-maven-plugin/blob/fixEmulatorStartBranch/noteEmulatorStartFix.txt
To contribute on this and other developments you can do a donation on : https://github.com/amanganiello90/maven-gitflow-plugin
Thanks you.