Add option to ignore allow_list for a certain route
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I just realised the template is not yet working. I'll give an update, once I fixed the issues and the PR is actually ready for a review. |
There are cases where most of the routes should only be allowed for the IP addresses defined in `allowlist`, but certain routes should be available publicly.
tomcbe
force-pushed
the
add-option-to-not-apply-allowlist-to-a-route
branch
from
522a8e2 to
3798334
Compare
|
Would now be ready for a review. |
andyundso
suggested changes
Jan 12, 2024
There was a problem hiding this comment.
I would appreciate if you can extend the reverse-proxy Molecule testing scenario. I imagine:
- in
molecule/reverse-proxy/converge.yml, add an additional entry tocaddy_siteslikemixed.example.com, one route will use an allowlist and the other one will be public. - Run
molecule create && molecule converge - Copy the generated Caddyfile from the Molecule container (using
molecule login, the Caddyfile is at/etc/caddy/Caddyfile) tomolecule/reverse-proxy/files/Caddyfile.expected.
Sure, I'll do that. |
|
As just discussed on slack: I'll change the name of the new variable to |
tomcbe
changed the title
public to routes to ignore site.allowlistallow_list for a certain route
andyundso
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where most of the routes should only be allowed for the IP addresses defined in
allowlist, but certain routes should be available publicly.