This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
Do not assume http_response_header set during exception #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable $http_response_header may not be set during an exception. A typical use case is calling out to the Twitter API during Twitter authentication when the callback URI has not been registered with Twitter. Because of how the Twitter API responds $http_response_header is not set and during the handling of the exception the missing $http_response_header masks the real issue. This commit changes the code to not assume that $http_response_header is set.
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
========================================
Coverage 0.00% 0.00%
- Complexity 79 80 +1
========================================
Files 4 4
Lines 296 297 +1
========================================
- Misses 296 297 +1 |
tvdijen
approved these changes
Apr 14, 2020
|
Thanks @skoranda ! Not to self: if you merge this, make sure to backport and tag v0.9.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable $http_response_header may not be set during an exception. A
typical use case is calling out to the Twitter API during Twitter
authentication when the callback URI has not been registered with
Twitter. Because of how the Twitter API responds $http_response_header
is not set and during the handling of the exception the missing
$http_response_header masks the real issue. This commit changes the code
to not assume that $http_response_header is set.