Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ld-monitor: Remove session.set_status() calls and define protocol in compose example #812

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

BrianJKoopman
Copy link
Member

Description

This removes the old session.set_status() calls that are automated in modern ocs. I also found another change to the configs we need, specifying UDP in the port mapping.

Motivation and Context

Ran into the status trying to go backwards when running at site:

2025-01-06T18:47:18+0000 startup-op: launching init_ld_monitor
2025-01-06T18:47:18+0000 start called for init_ld_monitor
2025-01-06T18:47:18+0000 init_ld_monitor:0 Status is now "starting".
2025-01-06T18:47:18+0000 init_ld_monitor:0 Status is now "running".
2025-01-06T18:47:18+0000 init_ld_monitor:0 CRASH: [Failure instance: Traceback: <class 'AssertionError'>:
/opt/venv/lib/python3.10/site-packages/twisted/internet/base.py:701:run
/opt/venv/lib/python3.10/site-packages/twisted/internet/base.py:709:mainLoop
/opt/venv/lib/python3.10/site-packages/twisted/internet/base.py:1063:runUntilCurrent
/opt/venv/lib/python3.10/site-packages/twisted/internet/threads.py:129:_callFromThread
--- <exception caught here> ---
/opt/venv/lib/python3.10/site-packages/twisted/python/threadpool.py:269:inContext
/opt/venv/lib/python3.10/site-packages/twisted/python/threadpool.py:285:<lambda>
/opt/venv/lib/python3.10/site-packages/twisted/python/context.py:117:callWithContext
/opt/venv/lib/python3.10/site-packages/twisted/python/context.py:82:callWithContext
/opt/venv/lib/python3.10/site-packages/ocs/ocs_agent.py:984:_running_wrapper
/opt/venv/lib/python3.10/site-packages/socs/agents/ld_monitor/agent.py:273:init_ld_monitor
/opt/venv/lib/python3.10/site-packages/ocs/ocs_agent.py:1279:set_status
/opt/venv/lib/python3.10/site-packages/twisted/internet/threads.py:135:blockingCallFromThread
/opt/venv/lib/python3.10/site-packages/twisted/python/failure.py:535:raiseException
/opt/venv/lib/python3.10/site-packages/twisted/internet/defer.py:212:maybeDeferred
/opt/venv/lib/python3.10/site-packages/ocs/ocs_agent.py:1285:set_status
]
2025-01-06T18:47:18+0000 init_ld_monitor:0 Status is now "done".

Also noticed the protocol defined as tcp when the container was online, though knew we wanted UDP.

How Has This Been Tested?

Tested the change at the site.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman merged commit 9242ab2 into main Jan 6, 2025
7 checks passed
@BrianJKoopman BrianJKoopman deleted the koopman/lightning-monitor-set-status branch January 6, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant