Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin sotodlib #806

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Pin sotodlib #806

merged 2 commits into from
Dec 20, 2024

Conversation

BrianJKoopman
Copy link
Member

@BrianJKoopman BrianJKoopman commented Dec 20, 2024 •
edited
Loading

Description

This PR pins sotodlib to the commit just before Python 3.8 support was dropped. I also removed some duplicate entries in requirements.txt.

Motivation and Context

sotodlib dropped 3.8 support (see simonsobs/sotodlib#1059), which breaks our builds here.

How Has This Been Tested?

It'll be tested in the CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman mentioned this pull request Dec 20, 2024
Open
@BrianJKoopman BrianJKoopman merged commit 3d8f152 into main Dec 20, 2024
5 checks passed
@BrianJKoopman BrianJKoopman deleted the koopman/pin-sotodlib branch December 20, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BrianJKoopman