Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace YieldingLock with ocs TimeoutLock #772

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

BrianJKoopman
Copy link
Member

@BrianJKoopman BrianJKoopman commented Oct 7, 2024

Description

This removes the original YieldingLock class from the 372 agent. This was merged upstream as TimeoutLock in ocs.

Motivation and Context

Resolves #152.

How Has This Been Tested?

This was tested with a 372 at Yale. The acq() process was left running while calling individual tasks that would cause an interaction with the TimeoutLock. Worked without issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code clean-up

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman force-pushed the koopman/replace-372-yieldinglock branch from 1ea4001 to df462a8 Compare October 16, 2024 15:13
@BrianJKoopman BrianJKoopman force-pushed the koopman/replace-372-yieldinglock branch from df462a8 to 0566909 Compare November 19, 2024 22:10
@BrianJKoopman BrianJKoopman marked this pull request as ready for review November 19, 2024 22:10
@BrianJKoopman BrianJKoopman merged commit 2847160 into main Nov 19, 2024
5 checks passed
@BrianJKoopman BrianJKoopman deleted the koopman/replace-372-yieldinglock branch November 19, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace YieldingLock in LS372 Agent with core ocs TimeoutLock
1 participant