Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new corrupt files table #110

Merged
merged 12 commits into from
Nov 14, 2024
Merged

Add new corrupt files table #110

merged 12 commits into from
Nov 14, 2024

Conversation

JBorrow
Copy link
Member

@JBorrow JBorrow commented Nov 12, 2024

NOTE BUILDS ON #105 DO NOT MERGE BEFORE #105

This adds a new table called 'corrupt files' that stores information about files that we have found to be corrupt during integrity checks.

@JBorrow JBorrow requested a review from iparask November 12, 2024 19:58
@iparask iparask changed the base branch from main to JBorrow/issue97 November 12, 2024 20:13
@iparask
Copy link
Member

iparask commented Nov 12, 2024

I rebased it to #105. It shows the diff better and when 105 gets merged this will automatically point to main

Copy link
Member

@iparask iparask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when a file is not corrupt any more? Does librarian delete the entry or does it keep it for historical reasons?

librarian_server/orm/file.py Show resolved Hide resolved
@JBorrow
Copy link
Member Author

JBorrow commented Nov 14, 2024

Handling corrupt files is left to a separate set of issues/PR #93

Base automatically changed from JBorrow/issue97 to main November 14, 2024 15:38
@JBorrow JBorrow linked an issue Nov 14, 2024 that may be closed by this pull request
@JBorrow JBorrow merged commit e15f99b into main Nov 14, 2024
5 checks passed
@JBorrow JBorrow deleted the JBorrow/issue106 branch November 14, 2024 15:44
@JBorrow JBorrow mentioned this pull request Dec 9, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store a table of 'corrupt' files that can be queried (and fixed)
2 participants