Merge pull request #614 from creative-commoners/pulls/6/php84

API Explicity mark nullable parameters for PHP 8.4

src/Dev/Benchmark.php

@@ -29,7 +29,7 @@ public static function start(string $id): void
      * @return string|null
      * @throws \Exception
      */
-    public static function end(string $id, string $message = null, bool $return = true): ?string
+    public static function end(string $id, ?string $message = null, bool $return = true): ?string
     {
         $benchmark = Benchmark::$benchmarks[$id] ?? null;
         if (!$benchmark) {

src/Dev/SchemaBuild.php

@@ -61,7 +61,7 @@ protected function getHeading(): string
      * @throws SchemaNotFoundException
      * @throws SchemaBuilderException
      */
-    public function buildSchema(string $key = null, bool $clear = true): void
+    public function buildSchema(?string $key = null, bool $clear = true): void
     {
         /** @var LoggerInterface $logger */
         $logger = Injector::inst()->get(LoggerInterface::class . '.graphql-build');

src/Schema/DataObject/CreateCreator.php

@@ -79,7 +79,7 @@ public function createOperation(
     public static function resolve(array $resolverContext = []): Closure
     {
         $dataClass = $resolverContext['dataClass'] ?? null;
-        return function ($obj, $args = [], $context = [], ResolveInfo $info = null) use ($dataClass) {
+        return function ($obj, $args = [], $context = [], ?ResolveInfo $info = null) use ($dataClass) {
             if (!$dataClass) {
                 return null;
             }

src/Schema/Services/SchemaTranscriber.php

@@ -38,7 +38,7 @@ class SchemaTranscriber
      * @param string $rootDir Storage path for the generated file.
      *                        Caution: This location may be used by frontend assets relying on GraphQL, e.g. silverstripe/assets.
      */
-    public function __construct(GraphQLSchema $schema, string $name, string $rootDir = null)
+    public function __construct(GraphQLSchema $schema, string $name, ?string $rootDir = null)
     {
         $this->fs = new Filesystem();
         $this->schema = $schema;

tests/Schema/SchemaTest.php

@@ -285,7 +285,7 @@ public static function noop()
     {
     }
 
-    private function buildSchema(string $key = 'test', SchemaConfig $context = null): Schema
+    private function buildSchema(string $key = 'test', ?SchemaConfig $context = null): Schema
     {
         $schema = new Schema($key, $this->createSchemaContext());