Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Use symfony/validation logic #11399

Merged
merged 1 commit into from
Oct 2, 2024
Merged

ENH Use symfony/validation logic #11399

merged 1 commit into from
Oct 2, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli marked this pull request as draft September 24, 2024 05:45
This was referenced Sep 24, 2024
Merged
Merged
Closed
Merged
Merged
Merged
Closed
@GuySartorelli GuySartorelli force-pushed the pulls/6/symfony-validation branch 2 times, most recently from 5e65ebd to 2a7f402 Compare September 24, 2024 22:25
@GuySartorelli GuySartorelli force-pushed the pulls/6/symfony-validation branch 2 times, most recently from d5b0656 to 68bc687 Compare September 24, 2024 23:29
@GuySartorelli GuySartorelli mentioned this pull request Sep 24, 2024
Merged
@GuySartorelli
Copy link
Member Author

CI failures are unrelated - PHPunit 11 doesn't like something about the xml config for this module.

emteknetnz
emteknetnz requested changes Sep 25, 2024
View reviewed changes
src/Security/Validation/EntropyPasswordValidator.php Show resolved Hide resolved
src/Security/Validation/AbstractPasswordValidator.php Outdated Show resolved Hide resolved
src/Security/Validation/AbstractPasswordValidator.php Outdated Show resolved Hide resolved
src/Security/Validation/AbstractPasswordValidator.php Outdated Show resolved Hide resolved
src/Security/Validation/AbstractPasswordValidator.php Outdated Show resolved Hide resolved
src/Security/Validation/RulesPasswordValidator.php Show resolved Hide resolved
src/Security/Validation/RulesPasswordValidator.php Show resolved Hide resolved
src/Security/Validation/RulesPasswordValidator.php Show resolved Hide resolved
src/Forms/ConfirmedPasswordField.php Show resolved Hide resolved
src/Security/Member.php Show resolved Hide resolved
@GuySartorelli GuySartorelli force-pushed the pulls/6/symfony-validation branch 2 times, most recently from 3c82db9 to 94dc070 Compare September 25, 2024 22:21
@GuySartorelli GuySartorelli marked this pull request as ready for review September 25, 2024 22:22
@GuySartorelli GuySartorelli force-pushed the pulls/6/symfony-validation branch from 94dc070 to eb49101 Compare September 30, 2024 20:45
@GuySartorelli
Copy link
Member Author

CI failures are related to previously merged sake work, and will be resolved in silverstripe/.github#313

emteknetnz
emteknetnz requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still getting unit test failures, do things need to be merged up?

Also there is a massive number of deprecation warnings from a third party library - is there anything we can do about that?

@GuySartorelli
Copy link
Member Author

The deprecation warnings are absolutely unrelated to this PR. As are the risky "Test code or tested code removed error handlers other than its own".

Failures are probably just things that needs this to be rebased on top of.

@GuySartorelli GuySartorelli force-pushed the pulls/6/symfony-validation branch from eb49101 to bdda469 Compare October 1, 2024 23:06
@emteknetnz emteknetnz merged commit 7f11bf3 into silverstripe:6 Oct 2, 2024
10 checks passed
@emteknetnz emteknetnz deleted the pulls/6/symfony-validation branch October 2, 2024 01:38
@GuySartorelli GuySartorelli mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz