Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Ignore phpstan errors we can't fix. #11326

Merged

Conversation

GuySartorelli
Copy link
Member

Requires silverstripe/silverstripe-standards#13 to be merged and tagged for CI to go green.

Issue

@emteknetnz
Copy link
Member

@GuySartorelli I reran CI after merging the silverstripe-standards PR - though I've just noticed that it didn't auto-tag (should've gone to 1.2.1), and it's missing an auto-tag.yml file

@GuySartorelli
Copy link
Member Author

auto-tag is for gha-* repos, but I see what you mean - gha-ci couldn't find tag-patch-release.yml despite that file existing.

I'll spin a separate card for that. For now I've manually tagged and rerun this linting job.

@emteknetnz emteknetnz merged commit 485bbc2 into silverstripe:5.2 Aug 6, 2024
15 checks passed
@emteknetnz emteknetnz deleted the pulls/5.2/phpstan-lint branch August 6, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants