Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Remove TODO comments #11032

Merged
merged 1 commit into from
Oct 30, 2023
Merged

MNT Remove TODO comments #11032

merged 1 commit into from
Oct 30, 2023

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova mentioned this pull request Oct 18, 2023
Closed
sabina-talipova
sabina-talipova commented Oct 19, 2023
View reviewed changes
sake Outdated Show resolved Hide resolved
GuySartorelli
GuySartorelli requested changes Oct 25, 2023
View reviewed changes
src/Control/HTTP.php Outdated Show resolved Hide resolved
src/ORM/FieldType/DBPolymorphicForeignKey.php Outdated Show resolved Hide resolved
src/ORM/Queries/SQLAssignmentRow.php Outdated Show resolved Hide resolved
src/Security/Member.php Outdated Show resolved Hide resolved
src/Security/MemberAuthenticator/MemberLoginForm.php Outdated Show resolved Hide resolved
src/Security/Permission.php Outdated Show resolved Hide resolved
tests/behat/src/CmsUiContext.php Outdated Show resolved Hide resolved
GuySartorelli
GuySartorelli approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 0887170 into silverstripe:5.1 Oct 30, 2023
15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.1/remove-todo branch October 30, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli