Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW Generate a random password if a blank password is entered #10974

Merged

Conversation

emteknetnz
Copy link
Member

Issue #10940

@emteknetnz emteknetnz force-pushed the pulls/5/random-password branch 3 times, most recently from 2216a3e to 32006fb Compare October 12, 2023 04:21
lang/en.yml Outdated Show resolved Hide resolved
src/Forms/ConfirmedPasswordField.php Outdated Show resolved Hide resolved
src/Forms/ConfirmedPasswordField.php Outdated Show resolved Hide resolved
src/Forms/ConfirmedPasswordField.php Outdated Show resolved Hide resolved
src/Forms/ConfirmedPasswordField.php Outdated Show resolved Hide resolved
src/Forms/ConfirmedPasswordField.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/random-password branch 2 times, most recently from 9c62b26 to d984c29 Compare October 16, 2023 02:34
@emteknetnz emteknetnz changed the title ENH Generate a random password if a blank password is entered NEW Generate a random password if a blank password is entered Oct 16, 2023
@emteknetnz emteknetnz force-pushed the pulls/5/random-password branch from d984c29 to a6f581d Compare October 16, 2023 02:35
@emteknetnz
Copy link
Member Author

@GuySartorelli I've semi redone this PR

lang/en.yml Outdated Show resolved Hide resolved
src/Forms/ConfirmedPasswordField.php Outdated Show resolved Hide resolved
src/Forms/ConfirmedPasswordField.php Outdated Show resolved Hide resolved
src/Forms/ConfirmedPasswordField.php Show resolved Hide resolved
src/Forms/ConfirmedPasswordField.php Outdated Show resolved Hide resolved
src/Security/Member.php Outdated Show resolved Hide resolved
src/Security/Member.php Outdated Show resolved Hide resolved
src/Security/Member.php Outdated Show resolved Hide resolved
src/Security/Member.php Outdated Show resolved Hide resolved
src/Security/Member.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/random-password branch from a6f581d to fbf27dd Compare October 17, 2023 00:17
src/Forms/ConfirmedPasswordField.php Outdated Show resolved Hide resolved
src/Forms/ConfirmedPasswordField.php Outdated Show resolved Hide resolved
src/Forms/ConfirmedPasswordField.php Outdated Show resolved Hide resolved
src/Forms/ConfirmedPasswordField.php Outdated Show resolved Hide resolved
src/Forms/ConfirmedPasswordField.php Show resolved Hide resolved
src/Forms/ConfirmedPasswordField.php Show resolved Hide resolved
src/Security/Member.php Outdated Show resolved Hide resolved
src/Security/Member.php Outdated Show resolved Hide resolved
src/Security/Member.php Outdated Show resolved Hide resolved
src/Security/Member.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/random-password branch from fbf27dd to 399e6a4 Compare October 18, 2023 22:46
src/Security/Member.php Outdated Show resolved Hide resolved
src/Security/Member.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/random-password branch from 399e6a4 to d493ee9 Compare October 19, 2023 21:49
src/Forms/ConfirmedPasswordField.php Outdated Show resolved Hide resolved
src/Security/Member.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/random-password branch from d493ee9 to 159112c Compare October 19, 2023 22:37
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Works well, and seems to be appropriately secure.

@GuySartorelli GuySartorelli merged commit 64e2b5e into silverstripe:5 Oct 19, 2023
15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/random-password branch October 19, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants