-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW Generate a random password if a blank password is entered #10974
Merged
GuySartorelli
merged 1 commit into
silverstripe:5
from
creative-commoners:pulls/5/random-password
Oct 19, 2023
Merged
NEW Generate a random password if a blank password is entered #10974
GuySartorelli
merged 1 commit into
silverstripe:5
from
creative-commoners:pulls/5/random-password
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
emteknetnz
force-pushed
the
pulls/5/random-password
branch
3 times, most recently
from
October 12, 2023 04:21
2216a3e
to
32006fb
Compare
GuySartorelli
requested changes
Oct 13, 2023
emteknetnz
force-pushed
the
pulls/5/random-password
branch
2 times, most recently
from
October 16, 2023 02:34
9c62b26
to
d984c29
Compare
emteknetnz
changed the title
ENH Generate a random password if a blank password is entered
NEW Generate a random password if a blank password is entered
Oct 16, 2023
emteknetnz
force-pushed
the
pulls/5/random-password
branch
from
October 16, 2023 02:35
d984c29
to
a6f581d
Compare
@GuySartorelli I've semi redone this PR |
GuySartorelli
requested changes
Oct 16, 2023
emteknetnz
force-pushed
the
pulls/5/random-password
branch
from
October 17, 2023 00:17
a6f581d
to
fbf27dd
Compare
GuySartorelli
requested changes
Oct 17, 2023
emteknetnz
force-pushed
the
pulls/5/random-password
branch
from
October 18, 2023 22:46
fbf27dd
to
399e6a4
Compare
emteknetnz
force-pushed
the
pulls/5/random-password
branch
from
October 19, 2023 21:49
399e6a4
to
d493ee9
Compare
GuySartorelli
requested changes
Oct 19, 2023
emteknetnz
force-pushed
the
pulls/5/random-password
branch
from
October 19, 2023 22:37
d493ee9
to
159112c
Compare
GuySartorelli
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Works well, and seems to be appropriately secure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #10940